[AEP][medium] AEP-20260924-r3-REPO-F01: parse ISO times in the fallback page - #337
Conversation
|
Review of
Tier B on this SHA: 84, severity important. This commit does not merge. The production page parser is PR #329, not this fallback. |
a2e43cf to
91ab50c
Compare
3596190 to
2f91085
Compare
|
Fix pushed as The inline timestamp regex is written as Parent re-ran that test plus |
91ab50c to
fe09228
Compare
2f91085 to
3be98ff
Compare
The fallback document multiplied every timestamp by 1000. Unix numbers still do. Naive ISO strings are treated as UTC, and an unparseable value renders as a dash instead of Invalid Date.
3be98ff to
89fd7ff
Compare
Description
The inline fallback page, used only when
dashboard/index.htmlis missing, parses numbers as unix seconds and naive ISO strings as UTC. Unparseable values render as a dash. The regex is written so ruff accepts it and the JavaScript source still contains\d.This score is for
89fd7ff, replayed onto the squash of #336.git range-diffmarks it equal to the previously scored3be98ff.Type of Change
Testing
ruff check dashboard_server.pypassed.TestInlineDashboardTimestamppassed. Reviewgrok-tierb-337d-20260924confirmed the range-diff equality and re-ran both. No browser.Brutal Honesty
dashboard/index.html. The production page parser landed with [AEP][high] AEP-20260924-FE001: stop false dashboard status #329.EVIDENCE: ruff and TestInlineDashboardTimestamp on 89fd7ff; range-diff equal to 3be98ff; review grok-tierb-337d-20260924
SMOKE: targeted unittest only; bash scripts/smoke.sh was not run on this branch
BHS_SELF_DRAFT: 100
BHS_SELF_DRAFT_AGENT: grok-aep-fix-20260924
BHS_TIER_B: 100
BHS_TIER_B_AGENT: grok-tierb-337d-20260924
BHS_TIER_B_SEVERITY: none
BHS_OFFICIAL: 100
CARRY_FORWARD: none
DEFERRED_SCOPE: none
LOOP_ITERATIONS: 2
OPERATOR_OVERRIDE: none