fix(ui): trace-row click navigates to per-trace view#392
Open
emilkallioniemi wants to merge 1 commit into
Open
fix(ui): trace-row click navigates to per-trace view#392emilkallioniemi wants to merge 1 commit into
emilkallioniemi wants to merge 1 commit into
Conversation
The TraceMenuItem `Link` accepted a `traceIndex` prop but never forwarded it to the route's search params. As a result, clicking a trace row left the URL unchanged and the right-hand panel stayed on the eval-level view; users could only reach the per-trace view by manually editing the URL to add `?trace=N`. Forward `traceIndex` via TanStack Router's function-form `search` prop so the URL gains `?trace=N` on click while preserving other search params (e.g. `timestamp`). The top "Eval" row has no `traceIndex`, so `trace` becomes `undefined` and is dropped from the URL, returning the view to the eval-level panel. The existing schema already types `trace` as `z.number().optional()`, so no schema change is required.
🦋 Changeset detectedLatest commit: f0fc8fa The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@emilkallioniemi is attempting to deploy a commit to the Skill Recordings Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #391
The TraceMenuItem
Linkaccepted atraceIndexprop but never forwarded it to the route's search params. As a result, clicking a trace row left the URL unchanged and the right-hand panel stayed on the eval-level view; users could only reach the per-trace view by manually editing the URL to add?trace=N.Forward
traceIndexvia TanStack Router's function-formsearchprop so the URL gains?trace=Non click while preserving other search params (e.g.timestamp). The top "Eval" row has notraceIndex, sotracebecomesundefinedand is dropped from the URL, returning the view to the eval-level panel. The existing schema already typestraceasz.number().optional(), so no schema change is required.