Add all-day, status, organizer, and attendee properties to Event - #22
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Preserve false all-day values and non-mailto participant identifiers.
Review effort: Lite
Findings: None
What changed in this PR
Extends Event with EventKit-backed all-day, status, organizer, and attendee data plus JSON-LD serialization.
Changes:
- Adds Event properties and status mapping.
- Converts EventKit participants to
Person. - Adds serialization and round-trip tests.
| File | Summary |
|---|---|
Tests/OntologyTests/EventTests.swift |
Tests new mappings and serialization. |
Sources/Ontology/Types/Person.swift |
Converts participants to Person; non-mailto identifiers need preservation. |
Sources/Ontology/Types/Event.swift |
Adds event metadata and serialization; preserves false all-day status. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.