Accept connections only over loopback - #242
Merged
Merged
Conversation
mattt
marked this pull request as ready for review
September 24, 2026 12:59
Owner
Author
|
Smoke tested with two Macs on the same network:
Not covered: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iMCP's listener accepts connections on every IPv4 interface, so another device on the same network can reach it and trigger a connection prompt (#103). Since #229, the CLI connects over
127.0.0.1using the port from the Bonjour TXT record.This PR binds both listeners to the IPv4 loopback address. Bonjour still advertises the service and its port on every interface, but connections to a LAN address are refused. The CLI's fallback to the resolved service endpoint, which it uses only when the TXT record has no port, no longer connects.
Closes #103.