Repository navigation
Fix Voicemail mailboxes, message types, and durations - #270
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows up on #253 with fixes from trying the Voicemail service on a real store:
voicemails_fetchreads the inbox by default. A newmailboxparameter returns blocked or deleted messages, and each result names its mailbox.ZPROVIDERandZMESSAGETYPEinstead of the file extension. Some carrier voicemails are stored asm4a, and FaceTime video messages can be lowercasemov.ZDURATIONis 0, the duration comes from the file's movie header.senderfilter match by digits, ignoring formatting.idaccepts an integer as well as a string.It also removes the voicemail store tests from the CLI test target. They'll move with the database access into a standalone package.