Integrate with deepseek v4pro addresses issue #90#91
Merged
Conversation
zshanhui
commented
May 31, 2026
Contributor
Author
There was a problem hiding this comment.
is this a generated file that needs to be commited?
Owner
There was a problem hiding this comment.
oh hmmm good question! most likely not.
zshanhui
commented
May 31, 2026
Comment on lines
+75
to
+80
| DEEPSEEK_V4_PRO_PRICING: dict[str, float] = { | ||
| "input_uncached": 0.435, | ||
| "input_cached": 0.003625, | ||
| "output": 0.87, | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
https://api-docs.deepseek.com/quick_start/pricing
(3) The deepseek-v4-pro model API pricing will be officially adjusted to 1/4 of the original price after the 75% discount promotion ends on 2026/05/31 15:59 UTC.
zshanhui
commented
May 31, 2026
| def _model_and_provider(args: argparse.Namespace) -> tuple[str, str]: | ||
| model_id = str(args.model or default_model_from_env()) | ||
| provider = str(args.provider or _infer_provider(model_id)) | ||
| def _model_and_provider(args: argparse.Namespace) -> tuple[str | None, str]: |
Contributor
Author
There was a problem hiding this comment.
this was added to fix an existing issue when --provider is present, but no --model provided, it would resolve to gpt-5.5-2026-04-23 not the providers default model.
Owner
|
Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#90
Adds support for Deepseek V4 Pro
The core of the implementation is in
agent/providers/deepseek.py, most of the other files are wiring and generated prompts thats not too different from the existing providers.--provider deepseek, does not effect other paths.Commands Run
List the exact commands you ran locally to verify this change (e.g.,
just test-all,uv run articraft generate, etc.)uv run articraft --provider deepseek generate "Create a realistic articulated desk lamp with a weighted base, two hinged arms, and an adjustable lamp head."Checklist
just format,just lint,npm run lint).just smoke-testsorjust test-all).