Bump com.google.inject:guice from 5.1.0 to 7.0.0#254
Conversation
Bumps [com.google.inject:guice](https://github.com/google/guice) from 5.1.0 to 7.0.0. - [Release notes](https://github.com/google/guice/releases) - [Commits](google/guice@5.1.0...7.0.0) --- updated-dependencies: - dependency-name: com.google.inject:guice dependency-version: 7.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
📝 WalkthroughWalkthroughThe Maven dependency Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pom.xml`:
- Around line 258-263: The Guice dependency version 7.0.0 in the pom.xml is
incompatible with Eclipse Sisu 1.0.0 and will break DI wiring used by
SisuBooter.java and SisuLookup.java; fix by either changing the
com.google.inject:guice dependency to a compatible version in pom.xml (e.g.,
6.2.2 or revert to 5.1.0) or by upgrading the Eclipse Sisu dependency to a
release that explicitly supports Guice 7.0.0, then run a full build and
smoke-test SisuBooter and SisuLookup to confirm DI wiring works.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| <dependency> | ||
| <groupId>com.google.inject</groupId> | ||
| <artifactId>guice</artifactId> | ||
| <version>5.1.0</version> | ||
| <version>7.0.0</version> | ||
| <classifier>classes</classifier> | ||
| </dependency> |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Is Eclipse Sisu 1.0.0 compatible with Google Guice 7.0.0?
💡 Result:
No, Eclipse Sisu 1.0.0 is not compatible with Google Guice 7.0.0. Sisu is compatible with Guice versions in the range [3,7), which excludes 7.0.0. This compatibility statement was made for the preceding stable milestone 0.9.0.M4, and the 1.0.0 release plan confirms it is functionally equivalent to that milestone with some dependency updates (primarily for Java 25 support via ASM), but no changes indicating expanded Guice support. Project dependency management lists Guice 4.2.3, further indicating no upgrade to Guice 7.
Citations:
- 1: https://github.com/eclipse/sisu.inject/releases
- 2: https://github.com/eclipse-sisu/sisu-project/releases/tag/releases%2F1.0.0
- 3: https://github.com/eclipse-sisu/sisu-project/releases/tag/milestones%2F0.9.0.M4
- 4: https://projects.eclipse.org/projects/technology.sisu/releases/1.0.0/plan
- 5: https://eclipse.dev/sisu/dependency-management.html
🏁 Script executed:
#!/bin/bash
# Description: Check Sisu's declared Guice dependency and look for any compatibility notes
# Check if there are any test files that exercise Guice/Sisu integration
echo "=== Test files that may exercise Guice/Sisu integration ==="
fd -e java -i test | xargs rg -l -i "guice|sisu|injector" 2>/dev/null | head -20
# Look for any existing CI configuration that runs tests
echo -e "\n=== CI configuration files ==="
fd -i "\.yml$|\.yaml$" .github 2>/dev/null | head -10
# Check if there's documentation about Guice version requirements
echo -e "\n=== README or docs mentioning Guice ==="
rg -i "guice" README.md 2>/dev/null || echo "No Guice mention in README"Repository: maveniverse/mima
Length of output: 1145
Guice 7.0.0 is incompatible with Eclipse Sisu 1.0.0 and must be downgraded or Sisu must be upgraded.
Eclipse Sisu 1.0.0 (line 272) explicitly supports Guice versions in the range [3,7), which excludes 7.0.0. The version bump from 5.1.0 to 7.0.0 introduces a breaking incompatibility. Sisu 1.0.0 was released with no changes to expand Guice support beyond this range, only Java 25 updates via ASM.
Either:
- Downgrade Guice back to a version within the [3,7) range (e.g., 6.2.2 or 5.1.0), or
- Upgrade Eclipse Sisu to a version that explicitly supports Guice 7.0.0
This will cause runtime failures in the DI wiring used by SisuBooter.java, SisuLookup.java, and related components.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@pom.xml` around lines 258 - 263, The Guice dependency version 7.0.0 in the
pom.xml is incompatible with Eclipse Sisu 1.0.0 and will break DI wiring used by
SisuBooter.java and SisuLookup.java; fix by either changing the
com.google.inject:guice dependency to a compatible version in pom.xml (e.g.,
6.2.2 or revert to 5.1.0) or by upgrading the Eclipse Sisu dependency to a
release that explicitly supports Guice 7.0.0, then run a full build and
smoke-test SisuBooter and SisuLookup to confirm DI wiring works.
Bumps com.google.inject:guice from 5.1.0 to 7.0.0.
Release notes
Sourced from com.google.inject:guice's releases.
Commits
b0e1d0fset 7.0.0 release #s.f4a66b7Make error_prone_annotations dependency optional654032aInternal change.bee813bImprove MissingImplementationError to lazily calculate suggestions and standa...2d64067Use linked bindings for MapBinder/Multibinder/OptionalBinder aliases, instead...be0141cInternal change40a5bcfAvoid re-initializing factories that are already initialized. This is necessa...9ac4767Change the way we reference what 6.0 supports in the README, so it doesn't ge...24324caPrepare for the Guice 6.0 & 7.0 releases. This change does the following:49b1a33Remove redundant references to javax.{inject,persistence,servlet} and replace...You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Summary by CodeRabbit