fix(Vehicle): remove initial connect outer timeouts causing slow-link failures (Stable_V5.1) - #15023
Merged
DonLakeFlyer merged 1 commit intoSep 2, 2026
Conversation
Contributor
Build ResultsPlatform Status
All builds passed. Pre-commit
Pre-commit hooks: 2 passed, 76 failed, 7 skipped. Test Resultslinux-coverage-integration: 40 passed, 0 skipped Code CoverageCoverage: 69.9% No baseline available for comparison Artifact Sizes
Updated: 2026-09-02 18:33:13 UTC • Commit: b63fbf3 • Triggered by: Android |
DonLakeFlyer
force-pushed
the
RemoveInitialConnectTimeouts_Stable
branch
from
September 2, 2026 15:24
d18ee07 to
c45df53
Compare
… failures The fixed outer timeouts on each InitialConnectStateMachine state could fire on slow links (e.g. SiK radios) even though the underlying protocols (ParameterManager, PlanManager, ComponentInformationManager, StandardModes) handle their own timeouts/retries and always signal completion. Force-advancing on timeout left the vehicle half-initialized. ParameterManager gains a terminal initialParametersRequestFailed signal so the Parameters state can advance when the vehicle never answers PARAM_REQUEST_LIST. Also fixes GimbalController sending MAV_CMD_REQUEST_MESSAGE raw, which collided with RequestMessageCoordinator users in the command queue duplicate check and flakily failed the AVAILABLE_MODES fetch. Also improves timeout/failure logging visibility and sanitizes downloaded URL logging.
DonLakeFlyer
force-pushed
the
RemoveInitialConnectTimeouts_Stable
branch
from
September 2, 2026 17:27
c45df53 to
b63fbf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stable backport of #15020.
Cherry-pick of 85a1c6b. Only conflict was test/Vehicle/CMakeLists.txt: dropped the TrajectoryPointsTest entries (master-only, not part of this fix) and kept the new StandardModesTest entries.