fix(FTPManager): fall back to non-burst read when a burst cannot compete - #15028
Open
julianoes wants to merge 1 commit into
Open
fix(FTPManager): fall back to non-burst read when a burst cannot compete#15028julianoes wants to merge 1 commit into
julianoes wants to merge 1 commit into
Conversation
…lete A burst read streams packets until the end of the file and the protocol gives the client no way to ask for less, so a link which cannot absorb the stream delivers only the first few packets of every burst. Retrying the burst then makes the same small amount of progress each time and the download fails, even though every attempt demonstrably moved forward. Seen downloading a camera definition from a MAVSDK camera routed through PX4: PX4 forwards one message per loop iteration into a two-message buffer, so exactly two of the fourteen burst packets survived each round, and QGC gave up after three retries with a third of the file fetched. Record whatever has not arrived as missing and advance to the existing fill-missing-blocks state instead of failing. That path already requests one chunk at a time with kCmdReadFile and never has more than a single message in flight, so it is unaffected by whatever truncated the burst. It also covers a burst that delivers nothing at all, which makes the whole file one missing block. Healthy links are unaffected since this is only reached once the burst has already exhausted its retries.
Contributor
Build ResultsPlatform Status
All builds passed. Pre-commit
Pre-commit hooks: 2 passed, 76 failed, 7 skipped. Test Resultslinux-coverage-integration: 52 passed, 0 skipped Code CoverageCoverage: 70.6% No baseline available for comparison Artifact Sizes
Updated: 2026-09-03 03:58:11 UTC • Commit: 07df322 • Triggered by: MacOS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When trying out burst downloading xml files from a camera via PX4, the burst failed because PX4 would not forward more than two messages at a time, and MAVSDK sends them too quickly (to be addressed separately).
This change falls back to non-burst download if the burst fails.
Type of Change
Testing
Platforms Tested
Flight Stacks Tested
Screenshots
Checklist
Related Issues
By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).