Skip to content

ci(github): enable stale issue closing - #15036

Merged
DonLakeFlyer merged 1 commit into
mavlink:masterfrom
DonLakeFlyer:ci-stale-issues-live
Sep 3, 2026
Merged

ci(github): enable stale issue closing#15036
DonLakeFlyer merged 1 commit into
mavlink:masterfrom
DonLakeFlyer:ci-stale-issues-live

Conversation

@DonLakeFlyer

@DonLakeFlyer DonLakeFlyer commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #15027. Removes debug-only so the stale workflow starts labeling and closing.

Dry-run results (run 33772184852)

Non-feature issues Feature requests
Would be marked stale ~656 150
Skipped: exempt label 106
Skipped: milestone 35 23
PRs touched 0 0

Exemptions behaved as intended; no errors.

Changes from the dry-run config

  • operations-per-run: 2500 (was 1500). The dry run showed each marked issue costs ~3 API ops and the org rate limit is 15000/hr, so a higher cap lets one run cover the full backlog with plenty of headroom.
  • exempt-issue-assignees: 'DonLakeFlyer,HTRamsey' in both jobs. Issues assigned to active maintainers stay open; the ~35 assigned to maintainers no longer active on QGC are allowed to age out normally.

Pre-work already done

The 68 open issues that carried a manually applied stale label had that label removed so they enter the normal 90-day + 30-day cycle rather than closing on the first live run.

What happens after merge

  • First nightly run (01:30 UTC) labels ~600 inactive issues stale silently (the dry-run counts above minus ~200 now exempt by assignee) (no comment).
  • 30 days later, issues still inactive are closed with the type-specific message.
  • Any comment or edit on a labeled issue removes the label.

Dry run (actions run 33772184852) confirmed exemptions and counts, so
remove debug-only to go live. Findings from the dry run folded in:

- operations-per-run raised to 2500: each marked issue costs ~3 API ops
  and the org rate limit is 15000/hr, so one run covers the backlog.
- Issues assigned to active maintainers (DonLakeFlyer, HTRamsey) are
  exempt; assignments to inactive maintainers are allowed to age out.

The pre-existing manually applied `stale` labels were removed from all
68 open issues beforehand so they get the normal 90+30 day cycle.
Copilot AI balanced review requested due to automatic review settings September 3, 2026 15:59
@github-actions github-actions Bot added github_actions Pull requests that update GitHub Actions code size/XS labels Sep 3, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

⚠️ Build results unavailable — artifact download from one or more platform workflows failed
(likely artifact retention expiry or transient API error). The combined report cannot be generated for this run.

See the Build Results workflow run for details.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The configuration matches the documented rollout and supported actions/stale inputs.

Pull request overview

Enables live stale-issue management following the successful dry run.

Changes:

  • Removes dry-run mode.
  • Exempts active maintainers’ assigned issues.
  • Raises the per-run operation limit to process the backlog.
File summaries
File Description
.github/workflows/stale.yml Activates labeling/closing and updates exemptions and capacity.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@DonLakeFlyer
DonLakeFlyer merged commit adca4c8 into mavlink:master Sep 3, 2026
34 of 37 checks passed
@DonLakeFlyer
DonLakeFlyer deleted the ci-stale-issues-live branch September 3, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants