Conversation
…er-first-warning-rails61 FOUND-1705: fix deprecated reorder first warning in rails61 branch
ardahaal
approved these changes
Aug 28, 2026
|
Some how I still get notifications for this repo. I wanted to say hi. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Loosen the
activesupportversion constraint incomma.gemspecfrom< 6.1to< 9, allowing the gem to be used with Rails 8.Also includes:
take(1).firstinstead of.first(avoids deprecated ordered first warning in Rails 8)to_fsforActiveSupport::TimeWithZonevalues (Rails 8 deprecatesto_swith format arguments)Why
Rails 8 ships with activesupport 8.x. The previous constraint
< 6.1(and later< 8on the rails7 branch) prevented bundle resolution with Rails 8.Acceptance Criteria
comma.gemspecspecifiesactivesupport >= 4.2.0, < 9bundle installresolves withrails ~> 8.0How to test?
rails8branchbundle installwith a Gemfile pinningrails ~> 8.0bundle exec rspecNotes/concerns
Branches for rails7 (
rails7) and rails6.1 (rails61) are maintained separately for backward compatibility.Checklist: