Skip to content

[internal] Loosen activesupport constraint to support Rails 8 (FND-1038) - #23

Open
mykhi wants to merge 6 commits into
masterfrom
rails8
Open

[internal] Loosen activesupport constraint to support Rails 8 (FND-1038)#23
mykhi wants to merge 6 commits into
masterfrom
rails8

Conversation

@mykhi

@mykhi mykhi commented Aug 27, 2026

Copy link
Copy Markdown

What

Loosen the activesupport version constraint in comma.gemspec from < 6.1 to < 9, allowing the gem to be used with Rails 8.

Also includes:

  • Use take(1).first instead of .first (avoids deprecated ordered first warning in Rails 8)
  • Use to_fs for ActiveSupport::TimeWithZone values (Rails 8 deprecates to_s with format arguments)
  • Bump version to 4.3.3

Why

Rails 8 ships with activesupport 8.x. The previous constraint < 6.1 (and later < 8 on the rails7 branch) prevented bundle resolution with Rails 8.

Acceptance Criteria

  • comma.gemspec specifies activesupport >= 4.2.0, < 9
  • bundle install resolves with rails ~> 8.0
  • Existing CSV export specs pass

How to test?

  1. Check out rails8 branch
  2. Run bundle install with a Gemfile pinning rails ~> 8.0
  3. Run the spec suite: bundle exec rspec

Notes/concerns

Branches for rails7 (rails7) and rails6.1 (rails61) are maintained separately for backward compatibility.

Checklist:

  • Tests pass
  • Version bumped (4.3.3)

@mykhi mykhi self-assigned this Aug 27, 2026
@NiceMLT

NiceMLT commented Aug 28, 2026

Copy link
Copy Markdown

Some how I still get notifications for this repo. I wanted to say hi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants