Draft
Conversation
… KEYS along with Dycky Script support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
USBHIDGamepadand aGAMEPAD_SUPPORTEDflag, and instantiate/initialize aGamepaddevice when available inesp32-s3/hid_handler.cpp.pressGamepadButton()and a new command handlerGAMEPAD_TEST:<A|B|X|Y>inprocessHIDCommand()to send a short tap for A/B/X/Y buttons and report status via Serial;STATUSnow reports gamepad availability.esp32-s3/data/www/index.htmlwith A/B/X/Y buttons and atestGamepadButton()implementation inesp32-s3/data/www/script.jsthat uses the existing/api/commandpipeline to trigger tests.docs/API.mdand note the experimental feature inesp32-s3/README.md.Testing
rgto verify the newGAMEPAD_TESTreferences and UI changes, which reported the expected matches (success).git diff --checkstyle/consistency checks to ensure no trailing errors (success).python3 -m http.serverand captured a browser screenshot with Playwright to validate the new Gamepad Test card renders correctly (screenshot generated successfully).GAMEPAD_TESTcommands through the existing/api/commandflow in the UI (commands are emitted to Serial; runtime HID availability depends on the installed ESP32 core and will log an error ifUSBHIDGamepadis not present).Codex Task