Design-standard consistency + dead-code cleanup (review #7, #9, #12) - #47
Merged
Merged
Conversation
Resolves three findings from docs/CODE_REVIEW_2026-06-02.md: #9 — .caption2 rule vs. reality. Bumped 16 user-facing TEXT sites from .caption2 to .caption (the documented floor): ContactListView (count, last-interaction date, metVia name, pill name, +N overflow), MergeContactPickerView (email), ActivityListView (calendar source + contact/group counts + names), SubscriptionView (BEST VALUE, per-period, renewal disclaimer), SettingsView (store-error help), BackupRestoreView (type/device badges). rules.md now documents the only two .caption2 exceptions — inline SF Symbol glyphs (trend arrows, chip icons, chevrons) and Canvas spatial labels (network-graph node names) — so rule and code agree. The 8 remaining .caption2 uses are exactly those two exempt categories. #7 — stale "Icon 1 = 48×48". rules.md described icon1Size as 48×48 with a larger Location row/header for prominence; the code has icon1Size = 36 and Locations use the standard 36×36 collection row (verified: no view renders a 48pt badge; icon1Size is referenced only by its own definition). Corrected the Icon 1 section to 36 and replaced the obsolete "Location Row Layout"/"Location Detail Header" sections with "Locations use the standard collection row/header." #12 — dead code. Deleted Blackbook/Services/LocalSyncServer.swift (718 lines). The class was never instantiated; the live sync handlers are in BlackbookServer/App/BackupServer.swift. Keeping it invited editing the wrong file (the exact confusion recorded in the work log for PR #36). Regenerated pbxproj. No page-doc (.cursor/pages) sync needed — none referenced .caption2. No behavior change; fonts shift one tier on metadata. iOS 206 + 13 tests pass; macOS builds. Recommend a quick on-device glance at the Contacts table + Activities rows since the bump can nudge row heights. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Acts on three findings from
docs/CODE_REVIEW_2026-06-02.md.#9 — Resolve
.caption2rule vs. realityThe rule says "never
.caption2for user-facing content" but 24 uses existed. Decision: bump text content to.caption(the documented floor) and carve two narrow, documented exceptions so rule and code finally agree.ContactListView(count, last-interaction date, met-via name, pill name, "+N"),MergeContactPickerView(email),ActivityListView(calendar source + contact/group counts),SubscriptionView("BEST VALUE", per-period, renewal disclaimer),SettingsView(store-error help),BackupRestoreView(type/device badges).Canvasspatial labels (network-graph node names — larger text overlaps nodes). These size an icon or a canvas label, not body text.#7 — Correct stale "Icon 1 = 48×48"
rules.md described
icon1Sizeas 48×48 with a larger Location row/header. The code hasicon1Size = 36, and Locations use the standard 36×36 collection row (verified: no view renders a 48pt badge;icon1Sizeis referenced only by its own definition). Corrected the Icon-1 section to 36 and replaced the obsolete "Location Row Layout" / "Location Detail Header" sections with "Locations use the standard collection row/header."#12 — Delete dead code
Blackbook/Services/LocalSyncServer.swift(718 lines) was never instantiated; the live handlers are inBlackbookServer/App/BackupServer.swift. Deleted + regenerated pbxproj.Notes
.cursor/pages/*.mdsync needed — none referenced.caption2.Test plan
xcodegen generatedropped the deleted file's refs🤖 Generated with Claude Code