chore: remove unused bwrap binary from Docker image#244
Merged
Conversation
Bubblewrap (bwrap) sandbox is redundant inside Docker containers. Docker already provides namespace isolation, and running bwrap inside a container requires --privileged which weakens Docker's security model. The bwrap binary was added in v3.49.0 but serves no purpose in the containerized deployment.
|
🎉 This PR is included in version 3.49.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove unused Bubblewrap (bwrap) binary from Docker image.
Problem
The bwrap binary was added in v3.49.0 (PR #243) to support Kilo CLI's sandbox feature. However, sandbox functionality is redundant inside Docker containers because:
--privilegedor--cap-add SYS_ADMIN, which removes Docker's own security protectionsChanges
COPY --from=builder /tmp/bwrap /usr/local/bin/bwraplineVerification
go build ./...✓go test ./...✓go vet ./...✓