fix: detect and clean up failed container after docker run -d#249
Merged
Conversation
Some Docker versions return exit code 0 from 'docker run -d' even when the container cannot start (e.g. invalid network), leaving it in 'created' state. Add waitForContainerCreated() to poll container state after detached run, and clean up orphaned containers on failure.
|
🎉 This PR is included in version 3.50.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker run -dwhen the container never reaches running stateProblem
When a user specifies an invalid
--networkvalue duringkilo-docker sessions recreate, the container is created but never starts, leaving it in Docker'sCreatedstate. Some Docker versions return exit code 0 fromdocker run -din this scenario, making the error undetectable. The user sees no error — the recreate command exits cleanly and the orphaned container is never cleaned up.Solution
Add
waitForContainerCreated()that polls container state afterdocker run -dfor up to 5 seconds. If the container transitions toexitedorcreatedinstead ofrunning, it returns an error with the container's logs (which contain Docker's explanation, e.g.network service:nordvpn not found). The failed container is automatically cleaned up.Changes
cmd/kilo-docker/docker.go— AddwaitForContainerCreated()post-creation health checkcmd/kilo-docker/main.go— Integrate health check intorunContainerdefault case, add container cleanup on bothdockerRunDetachederror and health check failure paths