hotfix - #3
Open
Pavaea wants to merge 1 commit into
Open
Conversation
mboremski
requested changes
Mar 2, 2026
| # 2. Den Identifier gegen die Regex prüfen | ||
| unless regex.match(identifier) | ||
| # Fehlermeldung ausgeben, wenn es nicht passt | ||
| errors.add(:identifier, "entspricht nicht dem erforderlichen Muster (#{regex_string})") |
Owner
There was a problem hiding this comment.
- german string should be a label
- throwing the complete (potential multiline) regex here might result in an unreadable error-message
| end | ||
| rescue RegexpError => e | ||
| # Falls die eingegebene Regex im Admin-Bereich ungültig ist | ||
| errors.add(:identifier, "konnte nicht geprüft werden, da die Regex ungültig ist.") |
Owner
There was a problem hiding this comment.
german string should be a label
Comment on lines
+18
to
+25
| require_dependency File.expand_path('../lib/redmine_regexidentifier/project_patch', __FILE__) | ||
| unless Project.included_modules.include?(RedmineRegexidentifier::ProjectPatch) | ||
| Project.send(:include, RedmineRegexidentifier::ProjectPatch) | ||
| # Diese Zeile MUSST du in den Docker-Logs sehen | ||
| puts "================================================" | ||
| puts "!!! REGEX-PLUGIN: Patch wurde geladen !!!" | ||
| puts "================================================" | ||
| end No newline at end of file |
Owner
There was a problem hiding this comment.
The change works as a workaround, but I’d prefer to keep the initialization inside a Rails.configuration.to_prepare (or a similar hook) to stay closer to the usual Redmine/Rails plugin pattern.
The explicit included_modules check is nice and helps to avoid double includes, so that part looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.