feat: migrate to remix v3 #98
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| packages/wordle/app/generated/** linguist-generated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../AGENTS.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| name: 🧪 Test | ||
|
|
||
| on: | ||
| push: | ||
| pull_request: | ||
|
|
||
| env: | ||
| DATABASE_URL: postgresql://postgres:password@localhost:5432/remix_wordle_test | ||
| REDIS_URL: redis://localhost:6379 | ||
| SESSION_SECRET: thisisaverysecuresecret1234567890 | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| test: | ||
| name: 🧪 Test | ||
| if: github.repository == 'mcansh/remix-wordle' | ||
|
|
||
| runs-on: ubuntu-slim | ||
| steps: | ||
| - name: ⬇️ Checkout repo | ||
| uses: actions/checkout@v5 | ||
|
|
||
| - name: ⎔ Setup node | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version-file: ".node-version" | ||
|
|
||
| - uses: pnpm/action-setup@v4 | ||
| name: 🟧 Install pnpm | ||
| with: | ||
| cache: true | ||
|
|
||
| - name: 🟧 Install dependencies | ||
| run: pnpm install --recursive --frozen-lockfile --strict-peer-dependencies | ||
|
|
||
| - name: 🛠️ Build | ||
| run: pnpm run build | ||
|
|
||
| - name: 🧪 Run Tests | ||
| run: pnpm run test | ||
|
Comment on lines
+16
to
+43
Contributor
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: cat -n .github/workflows/test.ymlRepository: mcansh/remix-wordle Length of output: 1312 🏁 Script executed: # Search for test configuration files
fd -e "jest.config" -e "vitest.config" -e "test.env" -e ".mocharc" -e ".babelrc" 2>/dev/null | head -20Repository: mcansh/remix-wordle Length of output: 45 🏁 Script executed: # Look for any test files to understand what they test
fd -type f -name "*.test.*" -o -name "*.spec.*" 2>/dev/null | head -10Repository: mcansh/remix-wordle Length of output: 45 🏁 Script executed: # Search for localhost references in the codebase
rg "localhost" --type-list | head -5Repository: mcansh/remix-wordle Length of output: 452 🏁 Script executed: # Search for environment variables related to databases
rg "DATABASE_URL|REDIS_URL|POSTGRES|postgres" --type js --type ts --type json -i | head -20Repository: mcansh/remix-wordle Length of output: 2181 🏁 Script executed: # Check for docker-compose or similar setup
fd docker-compose | head -10Repository: mcansh/remix-wordle Length of output: 81 🏁 Script executed: # Check package.json for test script and any setup
rg "test" package.json -A 5 -B 5Repository: mcansh/remix-wordle Length of output: 388 🏁 Script executed: # Look for any setup files or test initialization
fd -type f -name "setup*" -o -name "*.setup.*" 2>/dev/null | head -10Repository: mcansh/remix-wordle Length of output: 45 🏁 Script executed: cat -n docker-compose.ymlRepository: mcansh/remix-wordle Length of output: 647 🏁 Script executed: # Check the actual test script in the wordle package
fd -type f package.json | xargs rg "test" -A 3 -B 1Repository: mcansh/remix-wordle Length of output: 14014 Add Postgres and Redis services to the workflow. The environment variables 🔧 Proposed fix (service containers) jobs:
test:
name: 🧪 Test
if: github.repository == 'mcansh/remix-wordle'
+ services:
+ postgres:
+ image: postgres:15
+ env:
+ POSTGRES_USER: postgres
+ POSTGRES_PASSWORD: password
+ POSTGRES_DB: remix_wordle_test
+ options: >-
+ --health-cmd pg_isready
+ --health-interval 10s
+ --health-timeout 5s
+ --health-retries 5
+ ports:
+ - 5432:5432
+ redis:
+ image: redis:alpine
+ options: >-
+ --health-cmd "redis-cli ping"
+ --health-interval 10s
+ --health-timeout 5s
+ --health-retries 5
+ ports:
+ - 6379:6379🤖 Prompt for AI Agents |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| node_modules | ||
|
|
||
| /.cache | ||
| **/build/** | ||
| **/dist/** | ||
| .env | ||
| .DS_Store | ||
| **/coverage/** |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 24 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: mcansh/remix-wordle
Length of output: 45
🏁 Script executed:
Repository: mcansh/remix-wordle
Length of output: 595
🏁 Script executed:
Repository: mcansh/remix-wordle
Length of output: 1011
🏁 Script executed:
Repository: mcansh/remix-wordle
Length of output: 2313
Move hardcoded secrets to GitHub Secrets.
SESSION_SECRET,DATABASE_URL, andREDIS_URLshould not be hardcoded in the workflow. Use GitHub repository secrets instead to prevent credential exposure and reduce secret scanning noise.🔧 Proposed fix
📝 Committable suggestion
🧰 Tools
🪛 Checkov (3.2.334)
[medium] 8-9: Basic Auth Credentials
(CKV_SECRET_4)
[low] 10-11: Base64 High Entropy String
(CKV_SECRET_6)
🤖 Prompt for AI Agents