Make StatelessTransportState clonable in order to support overlapped …#204
Open
SamHSmith wants to merge 1 commit intomcginty:mainfrom
Open
Make StatelessTransportState clonable in order to support overlapped …#204SamHSmith wants to merge 1 commit intomcginty:mainfrom
SamHSmith wants to merge 1 commit intomcginty:mainfrom
Conversation
…key usage while rekeying.
mcginty
requested changes
Mar 24, 2026
Owner
mcginty
left a comment
mcginty
left a comment
There was a problem hiding this comment.
Hey thanks for the PR! However, I think this design needs to be reconsidered to not have panics, it feels like too much of a footgun.
Author
|
I guess I agree? But I don't see how you get around the fact that ring is fundamentally incompatible with this necessary feature for stateless transport. I guess just leave this unmerged until we come up with something. We will be using our fork with these changes so we are not blocked. |
Owner
|
@SamHSmith I'm thinking minimally something like a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…key usage while rekeying.