Allow text, add field, check for dict and append api_key#9
Open
fabaff wants to merge 1 commit intomchwalisz:developfrom
fabaff:develop
Open
Allow text, add field, check for dict and append api_key#9fabaff wants to merge 1 commit intomchwalisz:developfrom fabaff:develop
fabaff wants to merge 1 commit intomchwalisz:developfrom
fabaff:develop
Conversation
Author
|
Any news on this? |
Owner
|
This breaks the tests (even with the correct environment variables). |
Shouldn't the parameter order be inverted? As with any dictionary you should put the key first IMHO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a couple of changes related to #8 to get the upload working. Sorry, I'm not a ThingSpeak expert.
idoptional as it's not needed for updatesdatais dict and api_key can be attachedMy test case