Feature/use docker proxy - #1
Conversation
…ent variable Added support for Docker API proxy URL configuration.
📝 WalkthroughWalkthroughAdds a new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@caddy-agent-watch.py`:
- Around line 44-45: The default Docker socket URL uses the old double-slash
form; update the fallback in the _docker_base_url assignment to use the modern
triple-slash form "unix:///var/run/docker.sock" so that _docker_base_url =
DOCKER_PROXY_URL.strip() or os.getenv("DOCKER_HOST",
"unix:///var/run/docker.sock"); leave the DockerClient creation (client =
docker.DockerClient(base_url=_docker_base_url)) unchanged so it picks up the
corrected URL.
🧹 Nitpick comments (1)
caddy-agent-watch.py (1)
44-45: Consider logging the Docker base URL at startup for debugging.When troubleshooting Docker connectivity issues, it would be helpful to see which Docker endpoint is being used. The startup logging section (around line 1590) could include this information.
💡 Suggested addition to startup logging
Add after line 1590:
logger.info(f" Docker URL: {_docker_base_url}")
Summary by CodeRabbit
New Features
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.