Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes
best::dyna variadic template, so that you can have e.g.best::dynptr<reader, writer>, much like Rust has&dyn Read + Write. To enable this, the interface for implementing interfaces has changed.best::itableis the new name forbest::vtable, which in turn is now an alias for extracting aBestVtablefrom an interface type, which is the new name forBestFuncs.BestImplementsnow needs to return abest::vtable<I>by value, and machinery inside ofbest::itablewill automatically create a global variable for the result;best::itable::ofnow does more than just callBestImplements. This makesBestImplementsvery painless to implement by hand.best::itable<I, J, ...>no longer has anoperator->, since there is more than one vtable;operator[]can be used to get the vtable for a particular interface.best::dynptr<I, J, ...>provides access to the call interfaces forIandJviaoperator[]too.best::dyn::ofis nowbest::as_dyn(which itself was renamed tobest::dyn_of). This is so that it can be called with const interface values.best::interface_base, which allows us to force all interfaces to provide anof()static function, instead of having ti be convention.Also fixed
best::row::as_ref()being completely broken. Oops.