Add replacement for List.all#65
Merged
Merged
Conversation
Contributor
Author
PedroHLC
pushed a commit
to PedroHLC/elm-gobrrrrr
that referenced
this pull request
Jan 21, 2022
mdgriffith#65 Add replacement for List.all Add even faster replacement for List.all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This makes
List.allquite a lot faster. The problem is the original uses this implementation:The
composeL(or<<in Elm) is actually not very performant (benchmark, results). We could also make the same change by transformingcomposeL/composeRcalls by anonymous functions, but that's more work. I do plan to add that, at which point we can probably remove this replacement (EDIT: done in #73).I benchmarked the change. This is after compilation with
elm-optimize-level-2v0.2.3:Results on Chrome:

Results on Firefox:
I don't have a Safari readily available, but I'll try to get results later (work computer is a Mac, so I can get them later).