nltest: split multi-part messages into smaller batches#269
Merged
nickgarlis merged 1 commit intomdlayher:mainfrom Mar 18, 2026
Merged
nltest: split multi-part messages into smaller batches#269nickgarlis merged 1 commit intomdlayher:mainfrom
nickgarlis merged 1 commit intomdlayher:mainfrom
Conversation
The previous nltest implementation returned all multi-part messages except the Done message in a single Receive call. This made it difficult to verify that conn.Receive correctly loops over multiple Receive calls when draining multi-part responses. This change splits multi-part messages into batches of (n+1)/2 where n is the number of remaining messages, requiring multiple Receive calls to drain the full response. It also adds TestConnReceiveMultipart to verify that all expected messages are received and that subsequent Receive calls return no messages after the response is fully drained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous nltest implementation returned all multi-part messages except the Done message in a single Receive call. This made it difficult to verify that conn.Receive correctly loops over multiple Receive calls when draining multi-part responses.
This change splits multi-part messages into batches of (n+1)/2 where n is the number of remaining messages, requiring multiple Receive calls to drain the full response. It also adds TestConnReceiveMultipart to verify that all expected messages are received and that subsequent Receive calls return no messages after the response is fully drained.