Skip to content

Fixes issue #75#76

Merged
mdlincoln merged 2 commits into
mdlincoln:mainfrom
danielvartan:bugfix/issue-75
May 24, 2026
Merged

Fixes issue #75#76
mdlincoln merged 2 commits into
mdlincoln:mainfrom
danielvartan:bugfix/issue-75

Conversation

@danielvartan

Copy link
Copy Markdown
Contributor

Hi there 👋,

This Pull Request fixes a clipr issue that occurs on Wayland systems. You can find more details in issue #75.

Thank you!

@danielvartan

Copy link
Copy Markdown
Contributor Author

Please note that the checks failed due to issues with the package’s GitHub Actions and are unrelated to the changes in this PR.

Error: This request has been automatically failed because it uses a deprecated version of `actions/cache: v2`. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down

Copilot AI review requested due to automatic review settings May 24, 2026 17:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a Wayland-specific hang by changing how clipr probes for clipboard utilities on Linux, specifically avoiding a blocking wl-copy invocation during availability checks.

Changes:

  • Adjusts has_util() to call system2(..., stderr = FALSE) while probing utilities.
  • Updates the wl-copy probe to pass a text argument ("clipboard") so the command doesn’t block waiting for stdin.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread R/linux_clipboard.R
Comment thread R/linux_clipboard.R Outdated
@mdlincoln
mdlincoln merged commit 311c9ed into mdlincoln:main May 24, 2026
12 checks passed
@mdlincoln

Copy link
Copy Markdown
Owner

Thank you so much for finding the issue, fixing it, and extreme patience while I negletected this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants