Depend on typing-extensions for Python<3.11; avoid it otherwise#50
Open
musicinmybrain wants to merge 2 commits intomdomke:mainfrom
Open
Depend on typing-extensions for Python<3.11; avoid it otherwise#50musicinmybrain wants to merge 2 commits intomdomke:mainfrom
musicinmybrain wants to merge 2 commits intomdomke:mainfrom
Conversation
Conditionalize the import of `typing_extensions`, needed only in Python 3.10 and older; use `typing` instead for Python 3.11 and later. Add a dependency on `typing-extensions`, appropriately conditioned on the Python interpreter version. Based on mdomke#47 and mdomke#47 (comment). Fixes mdomke#44.
musicinmybrain
force-pushed
the
typing-extensions
branch
from
529095e to
05b54ba
Compare
|
This import could go in the Line 202 in 958a0eb |
Contributor
Author
That’s a great suggestion. Thanks. Updating with a follow-up commit… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conditionalize the import of
typing_extensions, needed only in Python 3.10 and older; usetypinginstead for Python 3.11 and later. Add a dependency ontyping-extensions, appropriately conditioned on the Python interpreter version.Based on #47 and #47 (comment).
Fixes #44.