Support filter keyword in where clauses. (#74)#82
Support filter keyword in where clauses. (#74)#82thromer wants to merge 5 commits intomdowds:masterfrom
Conversation
Doesn't support composite filters. # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # On branch master # Your branch is up to date with 'origin/master'. # # Changes to be committed: # modified: mockfirestore/collection.py # modified: mockfirestore/query.py # modified: tests/test_collection_reference.py #
|
Tests pass locally, including a new test that exercises the filter keyword argument to Collection.where and Query.where. |
Remove 3.6, add 3.11 and 3.12
|
This looks good, @mdowds any chance this could be merged? |
|
Is there any plan to merge this code and release a new version |
|
Any status on this PR? Would be really nice to get this merged so this package works with modern .where() syntax. |
|
Any updates on this?! Can this be merged and create a new release for the package? |
|
I have some local changes based of this PR that also implements compound queries, if I have time next week I'll fork this and make it available until this repo becomes active again. |
|
Thanks @eddie that would be great! Let me know if you'd like to fork it and publish it as a package, I can collaborate and help, I see the value in this. |
|
I have forked the repo, added @thromer 's changes and also initial compound query support, please test as its a bit crude! Hopefully we can get this merged back into the main repo in time. Thanks all. |
…al Firestore Python client.
Also, update Python version numbers and bump our version number.
5 participants
FieldFilter support only, not composite filters.