Add support for optional arguments in DocumentReference.get#87
Open
SHGoldfarb wants to merge 1 commit intomdowds:masterfrom
Open
Add support for optional arguments in DocumentReference.get#87SHGoldfarb wants to merge 1 commit intomdowds:masterfrom
SHGoldfarb wants to merge 1 commit intomdowds:masterfrom
Conversation
BenSchZA
added a commit
to ChaosLabsInc/python-mock-firestore
that referenced
this pull request
Jun 17, 2025
Add support for optional arguments in DocumentReference.get - mdowds#87
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #86.
Purposely does nothing with the optional arguments because the main value of supporting them is that tests will not fail with
TypeError: DocumentReference.get() takes 1 positional argument but X were given.