A fix for collections and collection streaming#91
Open
mjbosher wants to merge 7 commits intomdowds:masterfrom
Open
A fix for collections and collection streaming#91mjbosher wants to merge 7 commits intomdowds:masterfrom
mjbosher wants to merge 7 commits intomdowds:masterfrom
Conversation
mjbosher
commented
Jan 30, 2025
mjbosher
commented
- Fixes AttributeError where collection.id wasnt mocked
- Fixes TypeError in streaming where the keys were loaded as uuid4s and could not be compared to other collection keys
added 7 commits
January 30, 2025 09:28
…due to the code not explcitly converting uuid objects to strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.