Add missing opportunity scoring tier test coverage (supersedes #7) - #22
Merged
mdvnavy merged 1 commit intoJul 3, 2026
Merged
Conversation
Adds Quick Win and Full Integration tier tests for score_opportunity, originally proposed in PR #7 which was blocked by a merge conflict against main. This branch re-applies the same two tests cleanly on top of current main and imports ClientIntake to build fixtures directly. Verified: pytest -q -> 131 passed, 14 skipped (no regressions). Agent-Logs-Url: https://github.com/mdvnavy/Dia/sessions/a37077d2-cec6-48ce-aea8-9fc121c06536 Co-authored-by: mdvnavy <218024324+mdvnavy@users.noreply.github.com>
Claude created this pull request from a session on behalf of
mdvnavy
July 3, 2026 08:14
View session
mdvnavy
marked this pull request as ready for review
July 3, 2026 08:19
mdvnavy
deleted the
claude/add-missing-opportunity-scoring-tier-test-coverage
branch
July 3, 2026 08:19
There was a problem hiding this comment.
Pull request overview
This pull request improves regression protection for client_discovery.core.score_opportunity by adding explicit tests for the previously uncovered tier branches (Quick Win and Full Integration) on top of current main.
Changes:
- Import
ClientIntakeintotests/test_core.pyso tests can construct intake objects directly. - Add
test_score_opportunity_quick_win_tierto cover theQuick Wintier and price range. - Add
test_score_opportunity_full_integration_tierto cover theFull Integrationtier and price range.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
|
|
||
| def test_score_opportunity_quick_win_tier(): | ||
| intake = ClientIntake(pain_points=["pain1"], tools="") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-applies the test additions from PR #7 cleanly on top of current
main. PR #7 was created against a much older base and is in adirtymerge state (a hard conflict ontests/test_core.pyafter main added the Jules/OBS test suite). This PR delivers the same intended coverage improvement — nothing more.What changed
tests/test_core.pyfrom client_discovery.models import ClientIntaketo allow constructing intake objects directly in tests.test_score_opportunity_quick_win_tier— 1 pain point, no tools →Quick Win,$500-$2,500.test_score_opportunity_full_integration_tier— 4 pain points, 4 goals, with tools →Full Integration,$10,000-$25,000.Total diff: 1 file, +21 / -0. Same content that PR #7 proposed, transplanted verbatim on top of current main so it merges cleanly.
Why
Before this change, only the
Custom AI Agentbranch ofscore_opportunitywas covered by tests. TheQuick WinandFull Integrationbranches could regress silently. Together with the existingtest_score_opportunity_returns_tier_and_transparent_reasons, all three tier logic paths are now covered.Verification
python -m pytest tests/test_core.py -v→ 17 passedpython -m pytest -q(full suite) → 131 passed, 14 skipped (identical to pre-change baseline; no regressions)Relationship to PR #7
PR #7 (
add-missing-opportunity-tier-tests-3777336829010347368) branched fromb25ac393(pre-Jules/OBS merge). Since then, main added ~9 tests totests/test_core.pyat the exact insertion point PR #7 was targeting, plus asys.pathbootstrap block and new imports at the file header. Rebasing/merging PR #7 requires manually stitching both sides — which is exactly what this PR does. Once merged here, PR #7 can be closed as superseded.🤖 Generated with Claude Code