Ship the clean-machine trial fixes + accumulated content sync - #4
Merged
Conversation
Public export refreshed from private main (bad3654), catching up everything merged since the 2026-08-15 ontology/Siril export: - ASTAP capability probe + processing call now check astap_cli on PATH, not just astap; astap_star_db_path is now actually passed to the ASTAP subprocess (-d flag) instead of only being diagnosed. Both bugs were found live during the Run A Codespace trial and are the direct blockers to a clean Run B pass. - Manual crop/stretch review form works without the HTMX CDN (unpkg.com): native method/action + a real 303 redirect for non-htmx clients, falling back to the existing 200+HX-Redirect for htmx ones. - python-multipart added -- the actual cause of the review endpoint's 500 even after the HTML fallback landed (FastAPI needs it for any request.form() parsing). - Handbook + recipe-page content sync (unrelated accumulated work, already reviewed on the private side). Structural smoke (public_release_smoke.py) and sample verification (public_sample_verify.py) both pass; golden baseline remains correctly pending_second_machine. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RrtjAxPBEZpbrMWZGdYvxo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refreshes the public export from private
main(bad3654), which was stale at the 2026-08-15 ontology/Siril export. The change that actually matters for the clean-machine verification: three real bugs found live during the Run A Codespace trial, all fixed.doctor.py,seti_astro.py): capability probe and the real processing call only checkedastapon PATH, neverastap_cli-- a working install could report/behave as unavailable.astap_star_db_path(seti_astro.py): read from settings and diagnosed, but never actually passed to the ASTAP subprocess (-dflag) -- silently fell back to/usr/share/astap/data.review_web.py,main.py): the crop/stretch review form depends on HTMX fromunpkg.com; blocked/unavailable in the Codespace's browser, with no native fallback. Now degrades gracefully (nativemethod/action, real 303 redirect for non-htmx clients) and shipspython-multipart, the actual cause of a 500 even after the HTML fallback landed.The rest is unrelated accumulated content (Handbook articles, recipe-page tabs) already reviewed and merged privately since the last export -- bundled in because the export is a full sync, not a diff.
Verification
python scripts/public_release_smoke.py-- structural smoke PASSpython scripts/public_sample_verify.py-- sample package PASS, golden baseline correctly stillpending_second_machine🤖 Generated with Claude Code
https://claude.ai/code/session_01RrtjAxPBEZpbrMWZGdYvxo