Refactored selectfield.scss into _variables and _selectfield.scss#35
Open
yogeshgadge wants to merge 2 commits into
Open
Refactored selectfield.scss into _variables and _selectfield.scss#35yogeshgadge wants to merge 2 commits into
yogeshgadge wants to merge 2 commits into
Conversation
Author
|
@mebibou Please take a look. |
Author
|
@mebibou I realized you are publushing all the sources to npm - I guess then we don;t need this. Or you may plan to not publish the src to npm then I guess then this change will be useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored selectfield.scss into _variables and _selectfield.scss.
Gulpfile changes:
Copying scss files to dist
Other minor
gulpfile.jssimplifications.By refactoring we can let users of
mdl-selectfieldextend these variables and further customize in their project. For example someone may want to change color as in #34.Other cases are where certain projects may not want to directly include the css into their index.html (e.g. Angular projects). With this change they can bake their scss using these scss.