Skip to content

Cleanup params#21

Merged
julianu merged 13 commits into
mainfrom
cleanup_params
Oct 10, 2025
Merged

Cleanup params#21
julianu merged 13 commits into
mainfrom
cleanup_params

Conversation

@julianu
Copy link
Copy Markdown
Contributor

@julianu julianu commented Oct 10, 2025

Definition of params into config file, usage of schema

@julianu julianu requested a review from Copilot October 10, 2025 08:50
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR centralizes parameter definitions from individual Nextflow module files into a global configuration file and implements a schema for parameter validation. The changes move hardcoded container references and parameter definitions to enable better configuration management and consistency across the pipeline.

  • Move all parameter definitions from individual .nf files to nextflow.config for centralized management
  • Replace hardcoded container references with labels and implement container mapping in the docker profile
  • Add comprehensive nextflow_schema.json for parameter validation and documentation
  • Remove redundant nextflow.enable.dsl=2 declarations throughout modules

Reviewed Changes

Copilot reviewed 17 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
nextflow.config Centralizes all pipeline parameters and implements container label mapping
nextflow_schema.json Adds comprehensive parameter validation schema
main.nf Removes duplicated parameter definitions
src/preprocess/create_entrapment_database.nf Updates container reference to use labels and adds memory parameter
src/preprocess/create_decoy_database.nf Removes parameter definitions and updates container reference
src/preprocess/convert_to_mzml.nf Removes parameter definitions and updates container references
src/postprocessing/*.nf Removes parameter definitions and updates container references to use labels
src/identification/*.nf Removes parameter definitions and updates container references to use labels

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/preprocess/create_entrapment_database.nf
Comment thread nextflow_schema.json Outdated
@julianu julianu merged commit f66700a into main Oct 10, 2025
1 check passed
@julianu julianu deleted the cleanup_params branch October 10, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants