Cleanup params#21
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes parameter definitions from individual Nextflow module files into a global configuration file and implements a schema for parameter validation. The changes move hardcoded container references and parameter definitions to enable better configuration management and consistency across the pipeline.
- Move all parameter definitions from individual .nf files to nextflow.config for centralized management
- Replace hardcoded container references with labels and implement container mapping in the docker profile
- Add comprehensive nextflow_schema.json for parameter validation and documentation
- Remove redundant nextflow.enable.dsl=2 declarations throughout modules
Reviewed Changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| nextflow.config | Centralizes all pipeline parameters and implements container label mapping |
| nextflow_schema.json | Adds comprehensive parameter validation schema |
| main.nf | Removes duplicated parameter definitions |
| src/preprocess/create_entrapment_database.nf | Updates container reference to use labels and adds memory parameter |
| src/preprocess/create_decoy_database.nf | Removes parameter definitions and updates container reference |
| src/preprocess/convert_to_mzml.nf | Removes parameter definitions and updates container references |
| src/postprocessing/*.nf | Removes parameter definitions and updates container references to use labels |
| src/identification/*.nf | Removes parameter definitions and updates container references to use labels |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Definition of params into config file, usage of schema