feat(#804): var checks#805
Open
ChinHairSaintClair wants to merge 1 commit into
Open
Conversation
31612b9 to
31bc301
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Performs validation checks against form variables as configured through the related
<form>.properties.jsonfile.The proposed structure:
{ "var_restrictions": { "warn_length": <int>, "error_length": <int>, "ignore_list": <array>, "reserved_list": <array> } }Their functions:
warn_length: Print a warning with a list of vars whose length exceeds this limiterror_length: Throw an error with a list of vars whose length exceeds this limitignore_list: Exclude specified entries from either warning or error checksreserved_list: Throw an error, with list of relevant items, if any reserved entries match form variables.The feature also includes validation to guard against misconfiguration and surfaces these issues to the implementer. These include throwing an error if:
warn_lengthorerror_lengthcontains any value other than a positive integerwarn_lengthanderror_lengthare the sameignore_listorreserved_listcontain invalid valuesignore_listandreserverd_listIssue: 804
Code review items
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.