feat(#10908): support ordering header tabs by weight#11057
Merged
Conversation
Contributor
Author
|
@dianabarsan can you have a look at this when you get the chance? The refactoring here got pretty involved, so I wanted to give you a chance to see it in isolation before it goes into the main UI Extensions branch. 👍 |
7 tasks
Contributor
Author
|
The ordering/icons/functionality for all the tabs both in the header and the sidebar for both the new and old UIs should all work as expected. However, note that there are a few known styling issues with the UI Extensions in the legacy UI that are being addressed in #11017. So, if you notice any of those, just be aware that it is a known issue. |
dianabarsan
approved these changes
May 14, 2026
Member
dianabarsan
left a comment
There was a problem hiding this comment.
Sweet cleanup here! I pleasure to read really! I added some nits inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #10908
This PR adds support for ordering the main interface headers tabs according to the
weightproperty configured in the header_tabs app settings. Additionally, theheader_tabUI Extensions can also have aweightproperty that is used when factoring in the ordering of all the tabs. This ordering is honored both in the new and in the old UI.There was considerable duplication and complexity around the sidebar menu options between the new and the old UI. I have refactored the handling of these options to follow similar patterns with what we have for the main header tabs.
Documentation for the new config will be added in medic/cht-docs#2213
AI disclosure
Most of the unit test updates were made by Claude. I have reviewed all changes.
Code review checklist
can_view_old_navigationpermission to see the old design. Test it has appropriate design for RTL languages.License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.