fix(#10929): replace hardcoded English aria-labels with translation bindings on icon-only menu buttons#11061
Open
shivv23 wants to merge 17 commits into
Open
fix(#10929): replace hardcoded English aria-labels with translation bindings on icon-only menu buttons#11061shivv23 wants to merge 17 commits into
shivv23 wants to merge 17 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces hardcoded English
aria-labelattributes on icon-only menu buttons with proper translation bindings, adding translations for all 10 supported languages.Details
The accessibility bug
Four icon-only menu buttons had hardcoded
aria-labelvalues in English:"Application menu""Actions menu""Actions menu""Actions menu"These buttons have no visible text — they rely entirely on
aria-labelfor screen readers. Non-English users would hear English text, making the app partially inaccessible.The fix
HTML templates (4 files): Replaced
aria-label="..."with Angular's[attr.aria-label]="'...' | translate"so the label is fetched from translation files at runtime.Translation files (11 files): Added
actions.menuandapplication.menukeys to all 10 language files inapi/resources/translations/:Also added to
config/default/translations/messages-en.propertiesfor default config coverage.Impact
Screen reader users will now hear labels in their device language. No visual changes.
Testing
Verify the translated labels render correctly:
Closes #10929