refactor(webapp): replace any types in auth directive and training-card guard#11073
Open
aniketsingh1023 wants to merge 1 commit into
Open
refactor(webapp): replace any types in auth directive and training-card guard#11073aniketsingh1023 wants to merge 1 commit into
aniketsingh1023 wants to merge 1 commit into
Conversation
…rd guard Part of medic#10883. - auth.directive.ts: replace `mmAuthAny?: any` with a narrow union reflecting the runtime branches in `dynamicChecks` (a value is either `true` for short-circuit allow, a single permission name, or an AND-group of permission names; the input accepts a single value or an array of them representing OR-of-AND-groups). - training-card.guard.provider.ts: replace `CanDeactivate<any>` and `component: any` with `unknown`. The guard doesn't use the component parameter — `unknown` matches the actual contract while avoiding the `any` escape hatch. No runtime behavior changes. The new types match the existing call sites (no compile errors expected).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #10883.
Changes
webapp/src/ts/directives/auth.directive.ts: replacemmAuthAny?: anywith a narrow union (AuthAnyValue | AuthAnyValue[]) that reflects the runtime branches indynamicChecks— a value is eithertrue(short-circuit allow), a single permission name, or an AND-group of permission names; the input accepts a single value or an array of them representing OR-of-AND-groups.webapp/src/ts/training-card.guard.provider.ts: replaceCanDeactivate<any>andcomponent: anywithunknown. The guard does not use the component parameter —unknownmatches the actual contract without resorting toany.No behavior change
Pure typing change. No runtime logic touched. The new types match all existing call sites.