fix: log and propagate getUserSettings middleware failures#11086
Open
Dev10-sys wants to merge 1 commit into
Open
fix: log and propagate getUserSettings middleware failures#11086Dev10-sys wants to merge 1 commit into
Dev10-sys wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11051
Previously, if
auth.getUserSettings()failed, the error was caught and ignored without any log output. The request continued normally, making the failure difficult to detect and debug in production.Changes
getUserSettingscallsreq.authErrto match existing auth middleware behaviorTests
Added regression tests to verify:
req.authErris set properlyAll related authorization middleware tests are passing.