Port set-prototype-of to ext#107
Conversation
medikoo
left a comment
medikoo
left a comment
There was a problem hiding this comment.
@davidwallacejackson Great thanks for giving that a spin!
Please see my comments. In addition to them:
- Files as
.DS_Storeshould not be committed in - We need tests, and I know this part can be challenging, as different test suite is used in
ext. Old tests which can be found in _es5-ext/test and then need to be moved totestand refactored to new test runner (you can take inspiration from other reactors)
| @@ -0,0 +1,43 @@ | |||
| // Workaround for http://code.google.com/p/v8/issues/detail?id=2804 | |||
There was a problem hiding this comment.
To maintain changes history, ideally, if this is moved module from _es5-ext/object/create.js
| @@ -0,0 +1,7 @@ | |||
| "use strict"; | |||
There was a problem hiding this comment.
This should not be introduced (we should rely on type/object/is
| @@ -0,0 +1,10 @@ | |||
| "use strict"; | |||
There was a problem hiding this comment.
Those modules should be moved from _es5-ext/object/set-prototype-of
| @@ -0,0 +1,8 @@ | |||
| "use strict"; | |||
There was a problem hiding this comment.
This should not be introduced (we should rely on type/value/ensure)
medikoo
left a comment
medikoo
left a comment
There was a problem hiding this comment.
Additionally ideally if each main module is proposed as different PR.
So in context of this PR let's focus just on object/set-prototype-of and in next PR let's address object/create
2 participants
Giving this a shot! It looks like the implementations in the
testdirectory are generated/compiled, and I haven't figured out how to build them yet -- let me know and I'd be happy to do it!