Hwork2#2
Open
medvedevvu wants to merge 8 commits into
Open
Conversation
b00ris
reviewed
Dec 26, 2019
| func fiba(idx int) int { | ||
| fimap := map[int]int{0: 1, 1: 1} | ||
|
|
||
| switch idx { |
There was a problem hiding this comment.
Мне кажется можно заменить простой проверкой на наличие
There was a problem hiding this comment.
И достает функция из мапы тольок первые 2 элемента. А дальше считает.
| firstSlice := []int{1, 3, 11, 5, 6, 6, 7, 8, 9} | ||
| secondSlice := []int{0, 3, 11, 5, 6, 12, 7, 8, 9} | ||
| resmap := make(map[int]int) | ||
| firstSlice = append(firstSlice, secondSlice[:]...) |
There was a problem hiding this comment.
Это - упоминается хотя бы в одном из них. А нужно в обоих(пересечение).
|
|
||
| func main() { | ||
| var lText string = "спички топор молоток к веревка спички удочка молоток " | ||
| lTextarray := strings.Split(lText, " ") |
There was a problem hiding this comment.
Вполне корректно. Но правильнее было взять функцию https://golang.org/src/strings/strings.go?s=8396:8426#L319
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.