Repository navigation
chore(release): candidate v1.7.3 - #422
Conversation
Claude review status
✅ Review clean Last reviewed: New this round: 0 finding(s), 0 question(s) · Resolved this round: 1 · Open questions: 0 |
🧬 Mutation testingNo results at |
🧬 Spec-gate mutation — ✅ PASSNothing to test — no mutants were generated on the changed lines. |
Set the v1.7.1 release date and move the two API-breaking PRs into the v1.7.3 breaking changes list.
Merging this PR will not alter performance1 warning
Comparing Footnotes
|
There was a problem hiding this comment.
❓ Review complete — 1 open question(s)
Reviewed head 151d5cf9.
Release candidate v1.7.3: workspace version bump 1.7.1→1.7.3 in Cargo.toml / Cargo.lock / path-dep pins, plus auto-generated CHANGELOG additions.
Open questions — answer them in a reply on this PR. Each one is marked answered here once a later review round confirms the answer, so this list stays current:
✅ **Answered** — New preamble at CHANGELOG.md line 9 explains the duplication/#362 recategorization is intentional: v1.7.2 was a hotfix on v1.7.0 bypassing v1.7.1, so v1.7.3 first includes those PRs, and #362 is breaking here since it changed the public API. This is the annotation the prior review suggested.
- The new v1.7.3 section re-lists every PR that already appears under
## v1.7.1 (2026-09-08)(#360, #371, #362, #364, #358, #356, #374, #372, #361, #357, and the44116f6a10entry), and #362 is categorized "Refactoring" under v1.7.1 but "Breaking changes" under v1.7.3. Intentional (v1.7.2 branched before those PRs, so v1.7.3 is their first trunk release) or an artifact of the first gutenberg run not collapsing the pre-existing(unreleased)section into v1.7.3? - Why it matters: The PR states the GitHub Release body for v1.7.3 is this file's v1.7.3 section verbatim. If unintentional, the published CHANGELOG and release notes list the same PRs twice and contradict themselves on #362's category; if intentional, a short note in the CHANGELOG preamble would spare every future reader from asking the same question.
- How to verify: Confirm whether a v1.7.1 tag exists at 2026-09-08 and whether gutenberg's
release-candidateaction is expected to retain the pre-existing(unreleased)section alongside a freshly generated section that covers the same commit range. If intended hotfix-aware behavior, annotate the convention in CHANGELOG.md's preamble; otherwise regenerate so each PR appears in exactly one section.
….7.1 Add a note at the top of the v1.7.3 section saying why some entries repeat from v1.7.1 and why one is listed as breaking.
The note under v1.7.3 now has one sentence per line, matching the preamble at the top of the file.
Release candidate v1.7.3 (was 1.7.1).
Merging this PR creates the release branch
release-v1.7.3at the merge commit.It creates no tag; the tag is cut once, at settlement, by
release-settle→release-publish.Changelog: this release's entry is undated under
## v1.7.3; the GitHub Release body is the file's section verbatim.previous release's entry synced from its tag: inserted.
A refresh pushes a commit and therefore clears approvals under
require_last_push_approval, so the merge must be re-approved afterwards.