Skip to content

chore(release): candidate v1.7.3 - #422

Merged
RealiCZ merged 4 commits into
mainfrom
chore/release-candidate-1.7.3
Nov 20, 2026
Merged

RealiCZ merged 4 commits into
mainfrom
chore/release-candidate-1.7.3

Conversation

@mega-gutenberg

Copy link
Copy Markdown
Contributor

Release candidate v1.7.3 (was 1.7.1).

Merging this PR creates the release branch release-v1.7.3 at the merge commit.

It creates no tag; the tag is cut once, at settlement, by release-settle → release-publish.

Changelog: this release's entry is undated under ## v1.7.3; the GitHub Release body is the file's section verbatim.
previous release's entry synced from its tag: inserted.

A refresh pushes a commit and therefore clears approvals under require_last_push_approval, so the merge must be re-approved afterwards.

@mega-maxwell

mega-maxwell Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Claude review status

Living comment — rewritten in place. The review workflow keeps this single comment up to date instead of posting a new one each round, so it always describes the latest reviewed commit and the earlier text is intentionally gone. No reply is needed here; reply to a finding in its own review thread, and answer an open question in a reply on this PR. The next review round reconciles your answer.

✅ Review clean

Last reviewed: a3e13fd3..bf28d813 · updated 2026-11-20T02:19:47+00:00

New this round: 0 finding(s), 0 question(s) · Resolved this round: 1 · Open questions: 0

@github-actions

Copy link
Copy Markdown

🧬 Mutation testing

No results at target/mutants/mutants.out — nothing was mutated (e.g. no mutatable changes).

@github-actions

Copy link
Copy Markdown

🧬 Spec-gate mutation — ✅ PASS

Nothing to test — no mutants were generated on the changed lines.

Set the v1.7.1 release date and move the two API-breaking PRs into the v1.7.3 breaking changes list.
@RealiCZ RealiCZ added spec:unchanged No change to any `mega-evm`'s behavior comp:misc Changes to the miscellaneous part of this repo api:unchanged No change to the public interface or API labels Nov 20, 2026
@codspeed

codspeed Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ Unable to measure the execution of 16 benchmarks

These benchmarks measured no execution time, so their results are not comparable and count as unchanged. This usually happens when the compiler removes the code under test.

Prevent compiler optimizations

See affected benchmarks

✅ 359 untouched benchmarks
⏩ 30 skipped benchmarks1


Comparing chore/release-candidate-1.7.3 (bf28d81) with main (2161516)

Open in CodSpeed

Footnotes

  1. 30 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@mega-maxwell mega-maxwell Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Review complete — 1 open question(s)

Reviewed head 151d5cf9.

Release candidate v1.7.3: workspace version bump 1.7.1→1.7.3 in Cargo.toml / Cargo.lock / path-dep pins, plus auto-generated CHANGELOG additions.

Open questions — answer them in a reply on this PR. Each one is marked answered here once a later review round confirms the answer, so this list stays current:

✅ **Answered** — New preamble at CHANGELOG.md line 9 explains the duplication/#362 recategorization is intentional: v1.7.2 was a hotfix on v1.7.0 bypassing v1.7.1, so v1.7.3 first includes those PRs, and #362 is breaking here since it changed the public API. This is the annotation the prior review suggested.
  • The new v1.7.3 section re-lists every PR that already appears under ## v1.7.1 (2026-09-08) (#360, #371, #362, #364, #358, #356, #374, #372, #361, #357, and the 44116f6a10 entry), and #362 is categorized "Refactoring" under v1.7.1 but "Breaking changes" under v1.7.3. Intentional (v1.7.2 branched before those PRs, so v1.7.3 is their first trunk release) or an artifact of the first gutenberg run not collapsing the pre-existing (unreleased) section into v1.7.3?
  • Why it matters: The PR states the GitHub Release body for v1.7.3 is this file's v1.7.3 section verbatim. If unintentional, the published CHANGELOG and release notes list the same PRs twice and contradict themselves on #362's category; if intentional, a short note in the CHANGELOG preamble would spare every future reader from asking the same question.
  • How to verify: Confirm whether a v1.7.1 tag exists at 2026-09-08 and whether gutenberg's release-candidate action is expected to retain the pre-existing (unreleased) section alongside a freshly generated section that covers the same commit range. If intended hotfix-aware behavior, annotate the convention in CHANGELOG.md's preamble; otherwise regenerate so each PR appears in exactly one section.

….7.1

Add a note at the top of the v1.7.3 section saying why some entries repeat from v1.7.1 and why one is listed as breaking.

@mega-maxwell mega-maxwell Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Review needs attention — 1 finding(s)

0 blocking · 0 should-fix · 1 suggestion(s) · 0 open question(s)

Reviewed 151d5cf9..a3e13fd3.

Details are attached inline.

Comment thread CHANGELOG.md Resolved
The note under v1.7.3 now has one sentence per line, matching the preamble at the top of the file.
@RealiCZ
RealiCZ merged commit 904a621 into main Nov 20, 2026
37 of 38 checks passed
@RealiCZ
RealiCZ deleted the chore/release-candidate-1.7.3 branch November 20, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api:unchanged No change to the public interface or API comp:misc Changes to the miscellaneous part of this repo spec:unchanged No change to any `mega-evm`'s behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants