Skip to content

ci: attach mega-evme to the release at publication - #425

Draft
RealiCZ wants to merge 1 commit into
mainfrom
cz/ci/attach-mega-evme-to-release
Draft

RealiCZ wants to merge 1 commit into
mainfrom
cz/ci/attach-mega-evme-to-release

Conversation

@RealiCZ

@RealiCZ RealiCZ commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Do not merge before megaeth-labs/.github#59. Until #59 is on main, release-publish@main does not know asset_files. GitHub would then only warn about an unexpected input and publish the Release without the binary.

Summary

Releases here are immutable once published. on-release.yml runs after publishing, so it cannot attach assets; #424 removed that step for this reason. megaeth-labs/.github#59 adds an asset_files input to release-publish, which attaches files to the draft before the Release is published. This PR opts mega-evm in.

  • release-settle.yml
    • New build job:
      • runs only when the route says publish;
      • has contents: read and no environment, secrets or app token;
      • checks out the routed commit with submodules and builds mega-evme with --locked;
      • checks mega-evme --version against the release version;
      • uploads the binary as a workflow artifact.
    • publish now needs build, downloads the artifact and passes release-files/mega-evme as asset_files. release-publish adds SHA256SUMS itself.
    • If the build fails, publish does not run, so no tag is created.
  • on-release.yml: comments only. The registry upload is unchanged.
  • bump-version-release skill, step 4: updated to match.

The README "Prebuilt binary" sections stay out until a published release actually carries the binary. A follow-up will add them back, with a releases/latest/download/mega-evme link.

Test plan

  • release-settle.yml checked structurally against main:
    • route and refresh are unchanged;
    • publish differs only by needs, the download step and asset_files;
    • build has no credentials and every action is pinned to a commit SHA.
  • actionlint and app-token-lint pass on both workflows.
  • The asset_files path was rehearsed on real GitHub with immutable releases enabled. Results are in feat(release): attach assets before publication .github#59.
  • cargo build --release --locked -p mega-evme from a recursive clone of main builds and reports mega-evme 1.7.3.
  • The next release publishes with mega-evme and SHA256SUMS attached.

Labels checklist

  • spec: spec:unchanged
  • comp: comp:misc
  • api: api:unchanged

release-settle.yml now builds mega-evme in a credential-free job and passes it to release-publish as asset_files. Releases are immutable once published, so the binary must be attached before publication.
@RealiCZ RealiCZ added spec:unchanged No change to any `mega-evm`'s behavior comp:misc Changes to the miscellaneous part of this repo api:unchanged No change to the public interface or API labels Nov 20, 2026
@mega-maxwell

mega-maxwell Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Claude review status

Living comment — rewritten in place. The review workflow keeps this single comment up to date instead of posting a new one each round, so it always describes the latest reviewed commit and the earlier text is intentionally gone. No reply is needed here; reply to a finding in its own review thread, and answer an open question in a reply on this PR. The next review round reconciles your answer.

✅ Review clean

Last reviewed: head 1bb5100d · updated 2026-11-20T10:57:25+00:00

New this round: 0 finding(s), 0 question(s) · Resolved this round: 0 · Open questions: 0

@github-actions

Copy link
Copy Markdown

🧬 Mutation testing

No results at target/mutants/mutants.out — nothing was mutated (e.g. no mutatable changes).

Comment on lines +139 to +142
- name: Build mega-evme
run: cargo build --release --locked -p mega-evme

- id: version
@github-actions

Copy link
Copy Markdown

🧬 Spec-gate mutation — ✅ PASS

Nothing to test — no mutants were generated on the changed lines.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api:unchanged No change to the public interface or API comp:misc Changes to the miscellaneous part of this repo spec:unchanged No change to any `mega-evm`'s behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants