Repository navigation
Conversation
release-settle.yml now builds mega-evme in a credential-free job and passes it to release-publish as asset_files. Releases are immutable once published, so the binary must be attached before publication.
Contributor
Claude review status
✅ Review clean Last reviewed: head New this round: 0 finding(s), 0 question(s) · Resolved this round: 0 · Open questions: 0 |
🧬 Mutation testingNo results at |
Comment on lines
+139
to
+142
| - name: Build mega-evme | ||
| run: cargo build --release --locked -p mega-evme | ||
|
|
||
| - id: version |
🧬 Spec-gate mutation — ✅ PASSNothing to test — no mutants were generated on the changed lines. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Releases here are immutable once published.
on-release.ymlruns after publishing, so it cannot attach assets; #424 removed that step for this reason. megaeth-labs/.github#59 adds anasset_filesinput torelease-publish, which attaches files to the draft before the Release is published. This PR opts mega-evm in.release-settle.ymlbuildjob:publish;contents: readand no environment, secrets or app token;mega-evmewith--locked;mega-evme --versionagainst the release version;publishnow needsbuild, downloads the artifact and passesrelease-files/mega-evmeasasset_files.release-publishaddsSHA256SUMSitself.publishdoes not run, so no tag is created.on-release.yml: comments only. The registry upload is unchanged.bump-version-releaseskill, step 4: updated to match.The README "Prebuilt binary" sections stay out until a published release actually carries the binary. A follow-up will add them back, with a
releases/latest/download/mega-evmelink.Test plan
release-settle.ymlchecked structurally againstmain:routeandrefreshare unchanged;publishdiffers only byneeds, the download step andasset_files;buildhas no credentials and every action is pinned to a commit SHA.actionlintandapp-token-lintpass on both workflows.asset_filespath was rehearsed on real GitHub with immutable releases enabled. Results are in feat(release): attach assets before publication .github#59.cargo build --release --locked -p mega-evmefrom a recursive clone ofmainbuilds and reportsmega-evme 1.7.3.mega-evmeandSHA256SUMSattached.Labels checklist
spec:unchangedcomp:miscapi:unchanged