Skip to content

Fix clause marker rules setter - #264

Open
ikejourney wants to merge 1 commit into
megagonlabs:developfrom
ikejourney:fix-bunsetu-recognizer-clause-marker-rules
Open

Fix clause marker rules setter#264
ikejourney wants to merge 1 commit into
megagonlabs:developfrom
ikejourney:fix-bunsetu-recognizer-clause-marker-rules

Conversation

@ikejourney

Copy link
Copy Markdown

Summary

  • fix BunsetuRecognizer.clause_marker_rules setter to update _clause_marker_rules
  • compile regex patterns from each rule dictionary with rules.items()
  • add a small regression test for the property round trip

This is related to #211 because it covers one of the pipeline component property setting paths.

Checks

  • python3 -m py_compile ginza/bunsetu_recognizer.py ginza/tests/test_bunsetu_recognizer.py
  • git diff --check

I could not run pytest locally in this Codex environment because spacy is not installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants