Skip to content

ESD-1689: Test BGP JSON validation errors at a non-zero connection index #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Phil-Browne wants to merge 1 commit into
base: main
Choose a base branch
from
+43 −0
Open

ESD-1689: Test BGP JSON validation errors at a non-zero connection index #548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions internal/commands/vxc/vxc_inputs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1026,6 +1026,49 @@ func TestParseVRouterConfigBGP(t *testing.T) {
},
expectedError: "importWhitelist must be a number",
},
{
name: "second of two BGP connections wrong type reports index 1, not index 0",
config: map[string]interface{}{
"connectType": "VROUTER",
"interfaces": []interface{}{
map[string]interface{}{
"bgpConnections": []interface{}{
map[string]interface{}{
"peerAsn": 65000.0,
"localIpAddress": "192.168.1.1",
"peerIpAddress": "192.168.1.2",
},
map[string]interface{}{"shutdown": "yes"},
},
},
},
},
expectedError: "shutdown must be a boolean in BGP connection 1 of interface 0",
},
{
name: "third of three BGP connections wrong type reports index 2",
config: map[string]interface{}{
"connectType": "VROUTER",
"interfaces": []interface{}{
map[string]interface{}{
"bgpConnections": []interface{}{
map[string]interface{}{
"peerAsn": 65000.0,
"localIpAddress": "192.168.1.1",
"peerIpAddress": "192.168.1.2",
},
map[string]interface{}{
"peerAsn": 65001.0,
"localIpAddress": "192.168.1.3",
"peerIpAddress": "192.168.1.4",
},
map[string]interface{}{"medIn": "lots"},
},
},
},
},
expectedError: "medIn must be a number in BGP connection 2 of interface 0",
},
}

for _, tt := range tests {
Expand Down
Loading