ESD-1555: add marketplace visibility to the MVE buy request - #170
Open
Phil-Browne wants to merge 2 commits into
Open
ESD-1555: add marketplace visibility to the MVE buy request#170Phil-Browne wants to merge 2 commits into
Phil-Browne wants to merge 2 commits into
Conversation
BuyMVERequest had no marketplace-visibility field, so createMVEOrder never sent marketplaceVisibility on buy even though the order API accepts it via the shared DesignServiceBaseRequest base (merged into every product type). Add MarketplaceVisibility *bool to BuyMVERequest and the MVEOrderConfig wire struct and wire it through createMVEOrder, which ValidateMVEOrder also uses. Mirrors the MCR fix: *bool with omitempty so a nil value omits the key and keeps the API default rather than silently sending false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK couldn't set marketplace visibility when ordering an MVE.
BuyMVERequesthad no field for it andcreateMVEOrdernever sent one, so the buy payload omittedmarketplaceVisibilityeven though the order API accepts it. This is the MVE mirror of the MCR fix in #169.The buy endpoint takes an array of
MegaportServiceRequestwhose DESIGN variant mergesDesignServiceBaseRequest(which definesmarketplaceVisibility) viaallOfover every product type, so the field is accepted for MVE just like Port and MCR. Confirmed against the OpenAPI spec.MarketplaceVisibility *booltoBuyMVERequestand theMVEOrderConfigwire struct (marketplaceVisibility,omitempty).createMVEOrder, whichValidateMVEOrderalso uses, so validate carries it too.*bool+omitempty, not plainbool: a nil pointer omits the key so existing callers keep the API default instead of being silently flipped tofalse, matching #169 and theModify*Requestconvention.