Repository navigation
fix(binding): reject oversized final-value allocations - #26
Merged
Merged
Conversation
Compare source length to remainingNodes before destination allocation so oversized tuples, lists, and dicts fail with ErrValueLimit instead of preallocating from untrusted length.
Prove ConvertFinal returns ErrValueLimit for oversized tuples, lists, and dictionaries without allocating destination memory proportional to source length.
This was referenced Aug 25, 2026
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dict.Items()Verification
master: tuple 2,067,136 bytes; list 2,064,480 bytes; dictionary 17,680,784 bytesgo test ./internal/binding -count=1Server.Executereproduction: allocation reduced from 128,034,304 bytes to 64,013,840 bytes while preservingErrResourceLimitmise exec -- moon run root:checkThe remaining Starlark source allocation is outside final-value conversion; process isolation remains necessary for a hard heap boundary.
Closes #13