Repository navigation
refactor(execution): move native dispatch behind a port - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Behavior note
Native result objects now enter Starlark through the process-neutral map conversion path, which inserts keys in deterministic lexicographic order rather than Go struct declaration order. Tests pin this ordering before the worker protocol depends on it.
Review
One persistent reviewer completed bounded contract, slice, integration, fix, and lint-only passes. All blocking findings were fixed; the final pass reported zero merge blockers.
Verification
mise exec -- golangci-lint fmt --config .golangci.ymlgolangci-lint runfor root, binding, and execution packagesmise exec -- go test ./internal/execution -count=1mise exec -- go test . -run '^(TestDispatch|TestServerExecute)' -count=1Part of the worker-isolation remediation for #12; does not close the issue.