Repository navigation
test(server): stabilize elapsed-budget coverage - #40
Merged
Merged
Conversation
This was referenced Aug 25, 2026
jmgilman
added a commit
that referenced
this pull request
Aug 25, 2026
Follow-up review after #33-#40 landed: - Rewrite the Rego how-to verification against the current stdio tutorial; #34 deleted the in-process client it patched. - Show the literal tools/list wire schemas in the MCP reference (inlined field shapes, result: true) and fix the composite example's root output shape (field items, not a bare list root). - Add MaxIntermediateValueBytes to SECURITY.md's limit inventory. - Make disable-capabilities verification executable-shaped with exact inputs and expected tool errors. - Style repairs on new text: conditions before code, descriptive reference voice, removed 'normally'/'common'/'output universe', terminology and link fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Discovered while running final validation for #23.
Evidence
The prior 20ms setting failed intermittently because process spawn could consume the budget before authorization. The failure reproduced with
-race -count=5. After this change:go test -race . -run '^TestServerExecuteElapsedBudgetAfterAllowPreventsHandler$' -count=5golangci-lint run --config .golangci.yml . --show-stats=falseReview
Bounded review confirmed the old test failed spuriously rather than passing spuriously, the observable contract remains intact, and no assertion was weakened.