ci(release): drop the ghd distribution integration and fix the openapi smoke tests - #22
Merged
Merged
Conversation
…i smoke tests The release workflows validated and staged assets against a ghd.toml manifest that was intentionally removed; the ghd distribution channel is not part of this repo. Keep the goreleaser artifact/checksum validation and the dist/release-assets staging the rest of the release depends on, drop only the ghd.toml checks and the ghd download snippet in the release notes. Also fix both container smoke tests: 'openapi | grep -Fq' breaks the pipe when grep exits at the first match, failing docker run under pipefail; capture the spec to a file first. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #20 (the first release-please PR ever, and the first time the dry-run jobs actually executed) exposed two release-chain defects; both required checks on the release PR fail because of them.
1. ghd integration referenced a manifest that is intentionally absent.
ghd.tomlwas deliberately removed, but the workflows still validated against it. This PR removes the ghd surface entirely while keeping everything load-bearing:release-dry-run.yml: the validate step keeps the goreleaser artifact-completeness and checksum checks, drops only theghd.tomlassertions.stage_ghd_release_assets.py→stage_release_assets.py: staging intodist/release-assets/and checksum verification (used by the upload/smoke/attest jobs) are unchanged; only the ghd.toml validation is gone. Tests renamed/updated accordingly (5 pass).release.yml: step renamed, and theghd downloadsnippet removed from the generated release notes.2. Broken-pipe race in the container smoke tests (both workflows):
docker run ... openapi | grep -Fq— grep exits at the first match, the container is still writing the ~43KB spec,docker runfails withwrite /dev/stdout: broken pipeunderpipefail. Now captures the spec to a file and greps that.Testing
python3 .github/scripts/test_stage_release_assets.py→ 5 tests OK;test_configure_github_repo.pystill OK.ghdreferences remain under.github/.🤖 Generated with Claude Code