Skip to content

fix(packages): trust public APT TLS #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmgilman merged 1 commit into from
Aug 22, 2026
Merged

fix(packages): trust public APT TLS #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions internal/adapter/pkginstall/installer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ const (
const (
// aptInstallScript configures one signed source and verifies exact installed versions.
aptInstallScript = `set -eu
case "$REPOSITORY_ROOT" in
https://*)
apt-get update -qq
DEBIAN_FRONTEND=noninteractive apt-get install -y -qq ca-certificates >/dev/null
;;
esac
rm -f /etc/apt/sources.list.d/*
printf 'deb [signed-by=%s] %s/apt stable main\n' "$APT_KEY" "$REPOSITORY_ROOT" >/etc/apt/sources.list
apt-get update -qq
Expand Down
1 change: 1 addition & 0 deletions internal/adapter/pkginstall/installer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ func TestVerifyRunsThreeSignedLocalClientsWithoutNetworking(t *testing.T) {
assert.Equal(t, 3, countArgument(arguments, "release-cli"))
joined := strings.Join(arguments, "\n")
assert.Contains(t, joined, "signed-by=%s")
assert.Contains(t, joined, "apt-get install -y -qq ca-certificates")
assert.Contains(t, joined, "gpgcheck=1")
assert.Contains(t, joined, "repo_gpgcheck=1")
assert.Contains(t, joined, "apk update")
Expand Down