Changed to use DXC instead of SharpDX for HLSL compilation#102
Open
OpenPachinko wants to merge 2 commits into
Open
Changed to use DXC instead of SharpDX for HLSL compilation#102OpenPachinko wants to merge 2 commits into
OpenPachinko wants to merge 2 commits into
Conversation
|
DXC only supports compiling to DXIL, while DX11 (which e.g. Veldrid uses) only supports DXBC, so this would break compatibility with DX11 for binary HLSL! (I have no idea why Microsoft designed this stuff this way..) However, having cross compilation to DXBC isn't entirely out of the picture. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed to use DirectX Shader Compiler(DXC) instead of SharpDX for HLSL compilation.
SharpDX.D3DCompiler was for Windows only.
With the change to dxc, ShaderGen now works on Linux and MacOS.
https://github.com/microsoft/DirectXShaderCompiler